Remove payment type and login method from hanalytics #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can determine what this did locally through the selected Market, and not contact HAnalytics at all for it. This also makes connectPayinIntent just work with the selected market.
Expose the same function through the FeatureManager directly instead
StylianosGakis
force-pushed
the
refactor/remove_payment_type_from_hanalytics
branch
from
899d6f1 to
35a1fc3
Compare
StylianosGakis
changed the title
StylianosGakis
deleted the
refactor/remove_payment_type_from_hanalytics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now determine on how we login and what payment solution we pick purely form the market decision instead, which is exactly what HAnalytics was doing already