Moving flow fixes before release #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use the hedvig icon instead of the generic one. Remove the content description which was not precicly describing the action.
Make buildings content animate in individually, and not all items at all times whenever there is any chane. Done by applying the animation per item instead of for all items together. Use correct contentColor for button. Fix visibility modifiers for both functions Fix using `height` as a spacer in a row instead of `width` Fix greyed out text to use `onSurfaceVariant`
The function was returning a new list with the result instead of mutating the MutableList in-place. Removed the function altogether in favor of doing a simpler approach of removing the item if it's in there since we already got a mutable list to work with.
Remove "Destination" suffix from the offer screen, and remove turn EnterNewVillaAddress into EnterVillaInformation, as it better represents the functionality of that destination
Make back handling move normally through the backstack instead of exiting the entire flow in some scenarios. For this to work, instead of relying on some state being there for the navigation to trigger, instead handle that through event triggers baked in the ui state itself which the UI clears when the navigation event is properly handled. This allows the member to go back and forth to all moving flow destinations without having to exit the entire flow for no reason. Going forward again triggers the same path as before, overriding the old results in case of a new success response from the backend. Remove all BackHandler calls to support this. Keep ChangeAddressDestination.AddressResult outside of the AppDestination.ChangeAddress navigation graph, and make sure that when we do end up there, we do it after popping the entire backstack up to ChangeAddressDestination.AddressResult.
Allow HedvigInfoCard take in a new shape if the caller needs it to Make the small info card use the right squircle corner radius For cases where the divider is added on a list on all but the last item, prefer adding it in the first line by doing a much simpler `index > 0` check instead. Remove some non lokalised content description. Use the right icon for the info icon Use the right tint for the arrow showing that there is more info in the quote details card Remove the odd color for the ExpandablePlusCard which made it look different from the cards above, especially in dark mode. New colors match Figma instead.
More or less nothing of those had to be public and available to the :app module or anywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly UI fixes
Fix all the navigation handling so that going back does not exit the entire moving flow
Use movingFlowClient as a feature flag for this feature.