Remove embark #1855
Merged
Remove embark #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the deep link to point to for now while we still have one payment connection link.
The ones that are still relevant do it through androidx.navigation instead. The ones left are to be deleted when moving flow is out which allows us to delete the offer page.
Should now just be handled by the androidx.navigation deep link handling
To be passed to Trustly to get informed about success/failure
Octopus has to also contribute its metadata so that dependant modules can use its schema. In this case InitiateTrustlyConnectPaymentSession.graphql.
Some sample untested UI code for all of this to be tested when the presenter is hooked up correctly.
Just make the normal connect-payment, which is trustly for SE. Then add the second one for Adyen. This way the deep link goes to the Trustly one by default, but if you are in SE/NO you just get navigated to the right place. If not, nothing happens.
Wire up TrustlyPresenter Navigate to Adyen connect-payment in non SE market Use the right strings Use the right insets for the WebView
Simply do not render the layout until we get the screen size. This way the HomeLayout won't first assume the screen size has 0 height and try to lay out everything in a column at the top of the screen. This way the animated placement on the cards won't do the jump that it used to
Bump authlib and use the exposed PaymentRepository to fetch the right payment connection URL from there directly Add adyen screen and Presenter Add a special error case for when the initialization of connect payment fails, and not the connecting of the payment itself. Fix the loading bar in the WebViews by making it go on top of the WebView instead of pushing it when it appears.
Remove the entire Adyen SDK and all adjacent classes which use adyen related content, like the serializer in apollo-giraffe Remove the unused queries and mutations Update the readme with the updated instructions to get setup, and remove the Adyen related strings that were setup in CI Shrink PaymentRepository to only use the public API it needs, and remove the unused ones todo: Remove OfferActivity and Embark which also were depending on these classes
With this, other things are allowed to go, like: Fallbacks to embark claim flow and embark moving flow Offer screen entirely Legacy moving flow (Now, f-flag turns off the entire feature instead) Everything to do with the old quote_cart Danish address autocomplete Old Swedish login dialog (replaced with new login design) A bunch of giraffe queries and mutations CheckoutActivity Cross selling result (coming from Offer screen) Notification tracking activity Old Perils adapter Legacy change address HonestyPledgeBottomSheet A quack ton of XML files 😍 Some unused resources are for sure gonna be left after this, but they can always be eliminated gradually
All have been unused for over 1 year, and with the migration away from Giraffe, will never see use anyway
These are reported as trusted redirects from our backend, which we can use to be informed about when the connection is finished, successfully or not.
This also automatically fixes the issue with the payment information not being refreshed when the connection is done and you come back to this screen.
juliaendre
approved these changes
Nov 1, 2023
StylianosGakis
deleted the
refactor/remove_embark_offerscreen_quotecart
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, other things are allowed to go, like:
Fallbacks to embark claim flow and embark moving flow
Offer screen entirely
Legacy moving flow (Now, f-flag turns off the entire feature instead)
Everything to do with the old quote_cart
Danish address autocomplete
Old Swedish login dialog (replaced with new login design)
A bunch of giraffe queries and mutations
CheckoutActivity
Cross selling result (coming from Offer screen)
Notification tracking activity
Old Perils adapter
Legacy change address
HonestyPledgeBottomSheet
A quack ton of XML files 😍
The ones leftover are mostly for Chat. Common claims (Emergency activity) is bound to go soon too.