GEN-2831 Comparison API impl #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
fix/hc-multi-select-edit-insurance
to
fix/select-deductible-bugs
October 24, 2024 11:01
Merged
# Conflicts: # app/data/data-changetier/src/main/kotlin/com/hedvig/android/data/changetier/data/CreateChangeTierDeductibleIntentUseCase.kt # app/data/data-changetier/src/main/kotlin/com/hedvig/android/data/changetier/database/TierQuoteMapper.kt # app/data/data-chat/src/main/kotlin/com/hedvig/android/data/chat/database/ChangeTierQuoteEntity.kt # app/feature/feature-choose-tier/src/main/kotlin/com/hedvig/android/feature/change/tier/ui/stepcustomize/SelectTierDestination.kt
# Conflicts: # app/feature/feature-movingflow/src/main/kotlin/com/hedvig/android/feature/movingflow/ui/summary/SummaryDestination.kt
From the docs https://developer.android.com/develop/ui/compose/side-effects#derivedstateof "You should use the derivedStateOf function when your inputs to a composable are changing more often than you need to recompose. This often occurs when something is frequently changing, such as a scroll position, but the composable only needs to react to it once it crosses a certain threshold."
…ture/comparison-api
# Conflicts: # app/feature/feature-movingflow/src/main/kotlin/com/hedvig/android/feature/movingflow/ui/chosecoveragelevelanddeductible/ChoseCoverageLevelAndDeductibleDestination.kt
This ensures that the speed of the scroll does not get disproportionally affected by how big the screen itself is and if there are 3 or 4 columns
Gives the same effect as the table at: https://www.google.com/search?q=allsvenskan+tabell&oq=allsvenskan+&gs_lcrp=EgZjaHJvbWUqBwgBEAAYgAQyBggAEEUYOTIHCAEQABiABDIHCAIQABiABDIHCAMQABiABDIHCAQQABiABDIHCAUQABiABDIHCAYQABiABDIHCAcQLhiABDIHCAgQLhiABDIHCAkQABiABNIBCDMyODVqMGo3qAIAsAIA&sourceid=chrome&ie=UTF-8#sie=lg;/g/11vl2p3nsf;2;/m/045q93;st;fp;1;;; When the screen is small enough to make it scrollable
There was a 16.dp padding around the content making it look clipped. Move that padding to inside the items themselves so that the clickable indicator also is included in that space
Adds a not-placed text inside the cells as well so that its size changes along with the rest of the text.
By first constraining it to a maximum of 40% of the screen before using the max intrinsic size, we ensure both that the column won't overtake the entire width of the screen, while also making sure that if the texts require only part of the available space to them, then they will just take up the space they need, and no more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.