Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the extracted QuoteCard inside tier flow #2267

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Use the extracted QuoteCard inside tier flow #2267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a94bf9
Improve QuoteCard preview
StylianosGakis Nov 4, 2024
dcc7259
Rename file to the appropriate name
StylianosGakis Nov 4, 2024
2da2e8b
Use shared `QuoteCard` in tier flow summary screen
StylianosGakis Nov 4, 2024
b8a37fd
Remove pdf downloading logic from tier flow summary
StylianosGakis Nov 4, 2024
34317a9
Better name the animation dependency
StylianosGakis Nov 4, 2024
51f44b1
Remove pdf sharing glue code
StylianosGakis Nov 4, 2024
fb044d0
Remove duplicate call of `changeTierGraph`
StylianosGakis Nov 4, 2024
37cfe8e
Fix ui-tiers-and-addons dependencies
StylianosGakis Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ android {
dependencies {
implementation(platform(libs.firebase.bom))
implementation(libs.androidx.activity.compose)
implementation(libs.androidx.compose.animation)
implementation(libs.androidx.compose.animationCore)
implementation(libs.androidx.compose.foundation)
implementation(libs.androidx.compose.material3)
implementation(libs.androidx.compose.material3.windowSizeClass)
Expand Down
6 changes: 0 additions & 6 deletions app/app/src/main/kotlin/com/hedvig/android/app/navigation/HedvigNavHost.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,6 @@ internal fun HedvigNavHost(
openUrl = openUrl,
navigator = navigator,
)
changeTierGraph(
navigator = navigator,
navController = hedvigAppState.navController,
applicationId = hedvigBuildConstants.appId,
)
insuranceGraph(
nestedGraphs = {
terminateInsuranceGraph(
Expand Down Expand Up @@ -327,7 +322,6 @@ internal fun HedvigNavHost(
changeTierGraph(
navigator = navigator,
navController = hedvigAppState.navController,
applicationId = hedvigBuildConstants.appId,
)
movingFlowGraph(
navController = hedvigAppState.navController,
Expand Down
2 changes: 1 addition & 1 deletion app/audio-player-ui/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

dependencies {
implementation(libs.androidx.compose.animation)
implementation(libs.androidx.compose.animationCore)
implementation(libs.androidx.compose.foundation)
implementation(libs.androidx.compose.uiUtil)
implementation(libs.androidx.lifecycle.compose)
Expand Down
2 changes: 1 addition & 1 deletion app/feature/feature-choose-tier/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ dependencies {
implementation(projects.composeUi)
implementation(projects.coreCommonAndroidPublic)
implementation(projects.coreCommonPublic)
implementation(projects.coreFileUpload)
implementation(projects.coreResources)
implementation(projects.coreUiData)
implementation(projects.dataChangetier)
Expand All @@ -46,6 +45,7 @@ dependencies {
implementation(projects.navigationCompose)
implementation(projects.navigationComposeTyped)
implementation(projects.navigationCore)
implementation(projects.uiTiersAndAddons)

testImplementation(libs.apollo.testingSupport)
testImplementation(libs.assertK)
Expand Down
2 changes: 0 additions & 2 deletions ...choose-tier/src/main/kotlin/com/hedvig/android/feature/change/tier/di/ChooseTierModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.hedvig.android.feature.change.tier.di

import com.apollographql.apollo.ApolloClient
import com.hedvig.android.core.fileupload.DownloadPdfUseCase
import com.hedvig.android.data.changetier.data.ChangeTierRepository
import com.hedvig.android.feature.change.tier.data.GetCurrentContractDataUseCase
import com.hedvig.android.feature.change.tier.data.GetCurrentContractDataUseCaseImpl
Expand Down Expand Up @@ -60,7 +59,6 @@ val chooseTierModule = module {
params = params.get<SummaryParameters>(),
tierRepository = get<ChangeTierRepository>(),
getCurrentContractDataUseCase = get<GetCurrentContractDataUseCase>(),
downloadPdfUseCase = get<DownloadPdfUseCase>(),
)
}

Expand Down
6 changes: 1 addition & 5 deletions ...tier/src/main/kotlin/com/hedvig/android/feature/change/tier/navigation/ChooseTierGraph.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package com.hedvig.android.feature.change.tier.navigation
import androidx.compose.ui.platform.LocalContext
import androidx.navigation.NavController
import androidx.navigation.NavGraphBuilder
import com.hedvig.android.core.common.android.sharePDF
import com.hedvig.android.feature.change.tier.ui.chooseinsurance.ChooseInsuranceToChangeTierDestination
import com.hedvig.android.feature.change.tier.ui.chooseinsurance.ChooseInsuranceViewModel
import com.hedvig.android.feature.change.tier.ui.comparison.ComparisonDestination
Expand All @@ -24,7 +23,7 @@ import com.hedvig.android.navigation.core.Navigator
import org.koin.androidx.compose.koinViewModel
import org.koin.core.parameter.parametersOf

fun NavGraphBuilder.changeTierGraph(navigator: Navigator, navController: NavController, applicationId: String) {
fun NavGraphBuilder.changeTierGraph(navigator: Navigator, navController: NavController) {
navdestination<StartTierFlowDestination> { _ ->
val viewModel: StartTierFlowViewModel = koinViewModel {
parametersOf(this.insuranceId)
Expand Down Expand Up @@ -115,9 +114,6 @@ fun NavGraphBuilder.changeTierGraph(navigator: Navigator, navController: NavCont
onFailure = {
navigator.navigateUnsafe(ChooseTierDestination.SubmitFailure)
},
sharePdf = {
context.sharePDF(it, applicationId)
},
onSuccess = {
navigator.navigateUnsafe(ChooseTierDestination.SubmitSuccess(this.params.activationDate)) {
typedPopUpTo<ChooseTierDestination.SelectTierAndDeductible> {
Expand Down
Loading
Loading