Exit confirmation for moving flow #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embeds the logic of conditionally asking for confirmation before exiting the flow
Go away from using HedvigScaffold for this one as we need the extra customizability
Accomodates smaller screens by not hiding the buttons permanently.
panasetskaya
approved these changes
Nov 6, 2024
…-confirm-changes-for-summary-scree Make confirm changes section bottom attached
# Conflicts: # app/feature/feature-movingflow/src/main/kotlin/com/hedvig/android/feature/movingflow/ui/addhouseinformation/AddHouseInformationDestination.kt # app/feature/feature-movingflow/src/main/kotlin/com/hedvig/android/feature/movingflow/ui/successfulmove/SuccessfulMoveDestination.kt # app/feature/feature-movingflow/src/main/kotlin/com/hedvig/android/feature/movingflow/ui/summary/SummaryDestination.kt
…ving-flow' into feature/exit-confirmation-for-moving-flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a shared MovingFlowTopAppBar which handles adding the X button along with the confirmation dialog, when necessary
This requires removing HedvigScaffold in order to get more control over what we show, which results in some more code changes in the screens themselves