GEN-2539 New design/forever feature shared #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panasetskaya
commented
Nov 15, 2024
| } | ||
| LaunchedEffect(uiState.showEditReferralCodeBottomSheet) { | ||
| if (!uiState.showEditReferralCodeBottomSheet) { | ||
| delay(500) // to avoid extra animation effects on closing bottom sheet |
There was a problem hiding this comment.
okay, so this delay is ugly, I admit, but it's the only way that I could find to restore the unsubmitted value back on closing the BS and don't have a weird animation effect because of submit error/changed textFieldValue in the BS being restored at the same time as it is closing
panasetskaya
changed the title
…orever-feature-shared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forever UI to new DS.
Also I didn't really like how it looked while initially loading, so I added placeholder there.
And changed the structure quite a lot, since there were many workaround old bottom sheets, I think? Let me know what you think about it.
The success snackbar wasn't showing in prod, btw, so fixed that too