GEN-2542 Ds/insurances #2289
Merged
GEN-2542 Ds/insurances #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panasetskaya
approved these changes
Nov 15, 2024
| LazyColumn( | ||
| contentPadding = WindowInsets | ||
| .safeDrawing | ||
| .only(WindowInsetsSides.Horizontal + WindowInsetsSides.Bottom) | ||
| .exclude(consumedWindowInsets) |
There was a problem hiding this comment.
what was the problem with the insets here? was it orientation change? or tab changing?
| }, | ||
| ) { | ||
| if (hedvigBottomSheetState.data != null) { | ||
| content(hedvigBottomSheetState.data!!) |
There was a problem hiding this comment.
why do we need data here? in other words, I prob don't fully understand the usage of bottomSheetState :)
| modifier = Modifier.placeholder( | ||
| visible = isLoading, | ||
| highlight = PlaceholderHighlight.shimmer(), | ||
| shape = MaterialTheme.shapes.squircleLarge, | ||
| shape = HedvigTheme.shapes.cornerXLarge, |
There was a problem hiding this comment.
maybe diff corner here? placeholder look quite different from the button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed one thing which might affect other screens which was the default padding around the entire bottom sheet.
With previous implementation, if we passed nothing in the
sheetPaddingvalue it would also move the sheet up above the bottom navigation bar, which is never what we want to do anyway.This might have affected other callers as well, but I will try to go through them to make sure they look OK