New design/forever feature shared bottom with sheet state #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like this line prevents the children of this layout from using the insets apis properly, since they are now receiving information that the safeDrawing insets are already handled, but they are not actually consumed anywhere. Particularly, in landscape the cutout insets seem to not be inset here
Use HedvigBottomSheetState to store the information of the sheet. Dismiss it as normal when clicking "close" or when clicking outside. Also hook into the state of `showReferralCodeSuccessfullyChangedMessage` to dismiss it when it turns true, since we know that we have successfully submitted a code then. At the same time, remove the extra horizontal padding since the bottom sheet has a default of 16.dp horizontal which is what we wanted here.
Base automatically changed from
new-design/forever-feature-shared
to
develop
November 15, 2024 15:38
…with-sheet-state # Conflicts: # app/shared/forever-ui/src/main/kotlin/com/hedvig/android/shared/foreverui/ui/ui/ForeverDestination.kt
StylianosGakis
deleted the
new-design/forever-feature-shared-bottom-with-sheet-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing, but with HedvigBottomSheetState to control when the sheet shows or not.