Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-2544 New design/payments #2314

Merged
merged 25 commits into from
Nov 20, 2024
Merged

GEN-2544 New design/payments #2314

merged 25 commits into from
Nov 20, 2024

Conversation

panasetskaya
Copy link
Contributor

No description provided.

@panasetskaya panasetskaya requested a review from a team as a code owner November 19, 2024 13:08
@panasetskaya panasetskaya changed the title New design/payments GEN-2544 New design/payments Nov 19, 2024
Copy link

feature-payments

Copy link
Member

@StylianosGakis StylianosGakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try double checking the shapes as I mention in one of the comments. And that one place with the missing surface drew my attention a bit.
Super nice with all the changes here, and even with the card bug fix

@StylianosGakis
Copy link
Member

image Also noticed the error screen had the section be quite low in the screen itself. Is there some extra spacing at the top which could be removed, or is this a result of something else?

@panasetskaya panasetskaya merged commit c61d221 into develop Nov 20, 2024
4 checks passed
@panasetskaya panasetskaya deleted the new-design/payments branch November 20, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants