GEN-2547: travel certificate #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly refers to how this version of the state is an immutable object which needs to be re-created every time there is a new input in the date picker
This allows us to use the m3 sheet as-is, while not exposing the m3 types at all. travel-certificate date input screen was making use of this so we want to keep it intact Create `:design-system-api` for common interfaces both -internals and -hedvig need to access
# Conflicts: # app/feature/feature-payments/src/main/kotlin/com/hedvig/android/feature/payments/navigation/PaymentsGraph.kt
panasetskaya
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest diff comes from the fact that I needed to find a way to still allow travel-certificate use the datepickerstate it used to use, which came directly from m3.
To make it all work, I extracted an interface to a shared
design-system-apimodule, which both ds and ds-internals can see, where this new interface lives.Then as an implementation detail inside the
-detailsmodule, it delegates all operations to the m3 implementation, which it knows about.