GEN-2529 and GEN-2533: New DS in claim flow #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extracts it out of core.ui which is both used by many more callers who do not need access to this scaffold, but also leave the room open to shrink that module further or even remove it all together when we finish the new DS migration
Even if the input text is null, the card should keep a consistent height This emulates the behavior of the old HedvigBigCard to ease up migration
With it, :notification-permission too
Remove some leftover dependencies that were not migrated before
Ensure they are scrollable Add the top border when we've scrolled, as it was before Ensure the paddings around the content are set properly
| import com.hedvig.android.design.system.hedvig.icon.WarningFilled | ||
|
|
||
| @Composable | ||
| fun WarningTextWithIcon(text: String, modifier: Modifier = Modifier) { |
There was a problem hiding this comment.
are these ones not them ?
There was a problem hiding this comment.
no these are a bit of a custom thing, where in the flow if you do not select any pill you get this little warning on top of the pills
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.