DO NOT MERGE Make claim-flow navigation bar a shared element #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panasetskaya
approved these changes
Dec 11, 2024
|
I'll merge this once I'm back next year, so that I can monitor better if anything comes up due to it, even though I don't expect it to be problematic |
panasetskaya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes this top app bar stick around as the video showcases
shared_claim_flow_bar.mp4
This just wraps the entire app with a
SharedTransitionLayout, and sets up the local.And then uses the AnimatedContent local from the navigation itself to sync up the bar.
It's a successor to #2071 but much cleaner since we use the locals to make it all work instead of polluting the entire codebase with scopes and such.