Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to combat instructions for solo/coop scenarios #730

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

captain-yoshi
Copy link

Fixes #728.

en-31

sections/combat.tex Outdated Show resolved Hide resolved
sections/ai_rules.tex Outdated Show resolved Hide resolved
@captain-yoshi captain-yoshi force-pushed the combat-setup branch 2 times, most recently from 6046b38 to 62ac0a4 Compare October 28, 2024 14:14
@captain-yoshi
Copy link
Author

Rebased with master. Is there something to add for localisation ?

@qwrtln
Copy link
Collaborator

qwrtln commented Oct 28, 2024

Rebased with master. Is there something to add for localisation ?

Yes, you have to run po4a po4a.cfg. It will update the localization files.

@captain-yoshi
Copy link
Author

captain-yoshi commented Oct 28, 2024

Got this errror when running:

$ po4a po4a.cfg
sections/ai_rules.tex:53: (po4a::tex)
               unmatched end of environment 'multicols*'
po4a: Couldn't determine the input document's charset. Please specify it on the command line. (non-ASCII char at sections/all_map_locations.tex:38)

The non-ASCII char is the em dash from all_map_locations.tex at line 38

    \svg{gold}/\svg{building_materials}/\svg{valuablegreater} —

What would be the correct charset to use ?
https://linux.die.net/man/1/po4a

@qwrtln
Copy link
Collaborator

qwrtln commented Oct 28, 2024

We're using Unicode here, since LaTeX supports it at least since 2018. The workflow uses version po4a==0.73. If your distro ships with po4a<=0.69, you might encounter problems. You have two options:

  1. Download the latest po4a from GitHub: https://github.com/mquinson/po4a
  2. Create a PR in your fork targeting combat-setup branch, and type a comment po4a commit in there. A bot in the workflow will commit the necessary changes. After merging them, they'll be reflected here.

@qwrtln
Copy link
Collaborator

qwrtln commented Oct 28, 2024

Charset fixed by #731

@qwrtln
Copy link
Collaborator

qwrtln commented Oct 29, 2024

It shouldn't have changed that many files. As #731 was merged, try removing the latest commit, rebasing, and running again.

@qwrtln
Copy link
Collaborator

qwrtln commented Oct 29, 2024

You probably still have local po4a version mismatch (which one do you have, BTW?). Try the workflow approach.

@captain-yoshi
Copy link
Author

captain-yoshi commented Oct 29, 2024

Removed, rebased and run po4a cfg. It still seem to change a lot of files Using version po4a version 0.74-alpha. Maybe I should use a release version instead. What version do you use ?

@qwrtln
Copy link
Collaborator

qwrtln commented Oct 29, 2024

0.73

@captain-yoshi
Copy link
Author

captain-yoshi commented Oct 30, 2024

Had an error when building po4a but showed new version when installed...:

Malformed encoding while writing to file /home/captain-yoshi/ws/dev/po4a/blib/man/ca/man3/Locale::Po4a::Xml.3pm.pod with charset UTF-8: "\x{fffd}" does not map to UTF-8 at lib/Locale/Po4a/TransTractor.pm line 
542.
If UTF-8 is not the expected charset, you need to configure the right one with with --localized-charset or other similar flags.
Close with partial character at lib/Locale/Po4a/TransTractor.pm line 566.
Died at Po4aBuilder.pm line 191.

Anyway generated the localisation update through the action workflow and rebased.

@captain-yoshi
Copy link
Author

The CS printing gives 57 pages instead of 56 which might be normal. The strange thing is that this PR section has not been translated ?
image

@qwrtln
Copy link
Collaborator

qwrtln commented Oct 30, 2024

That's what po4a does. If there's an update to a part of the text (the bullet points in this case), it marks the translation as fuzzy, and uses the original as fallback. Every language will do that, that's why your change is rolled out to 8 po files. I think it should be parked until 1.3 release, as it's not a critical change, so as not to trouble translators.

@qwrtln qwrtln added the changes text Requires Heegu's approval label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes text Requires Heegu's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combat Setup: Add link to combat instruction for Solo and Cooperative scenarios
2 participants