Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more clearly wording on trading page #784

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

DerSchlupf
Copy link
Collaborator

@DerSchlupf DerSchlupf commented Jan 8, 2025

Hey together,

during german translation i found a few parts in the rewrite, where i think it could be more clear. I will create PRs for these parts in the next weeks and show you my suggestions. I will start with trading page, where i have 2 Suggestions (red marked) and 1 question (blue marked).

Here the page. See some notes below:
image

suggestion 1):
To prevent, that removing a card could be missunderstood as a rate (one gold per card). This questions comes up several times on discord. Clarification from alex:
image
https://discord.com/channels/740870068178649108/1211591995328299038/1268478582557249536

suggestions 2):
clarification from alex:
image
(https://discord.com/channels/740870068178649108/1211591995328299038/1317086052107817002). I know, that there is a small risk, because he wrote "he ask kamil", but there are many evidences, that it is addional. Because of that i suggest to change the wording and if we get another clarification we make it undone.

Question: What is meant by "other effects"? Are there effects in the game, where you have the same options like as visiting the tradining post?

@DerSchlupf DerSchlupf requested a review from Heegu-sama as a code owner January 8, 2025 15:26
@DerSchlupf
Copy link
Collaborator Author

po4a commit

Copy link

github-actions bot commented Jan 8, 2025

Changes committed successfully 🎉 Please update your local branch by running git pull 💻
Bear in mind that I am a bot 🤖 so I cannot trigger workflows!
Trigger them by pushing an empty commit: git commit --allow-empty -m "Trigger workflows" && git push.

@DarthGandalf DarthGandalf added the changes text Requires Heegu's approval label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes text Requires Heegu's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants