Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues introduced in PR #232 #233

Merged
merged 2 commits into from
May 11, 2024
Merged

Fix issues introduced in PR #232 #233

merged 2 commits into from
May 11, 2024

Conversation

BlitzOffline
Copy link
Member

@BlitzOffline BlitzOffline commented Apr 30, 2024 •
edited
Loading

  • removes ChatUser#playerNotNull in favor of using the ChatUser#player method which returns an optional (as discussed here: fix: bukkit player api usage #232 (comment))
  • upgrades adventure (for 1.20.5 and 1.20.6 support)
  • fixes 2 bugs introduced in PR fix: bukkit player api usage #232:
    • Player#toString being used instead of Player#getName in mention parsing which led to a regex exception being thrown
    • ChatChatPlugin#audiences being used in a try block resulted in it being closed after the first use

Tested on:

  • git-Paper-496 (MC: 1.20.4)
  • Java 17 (OpenJDK 64-Bit Server VM 17.0.5+8)
  • Linux 5.15.146.1-microsoft-standard-WSL2 (amd64)

@BlitzOffline BlitzOffline merged commit 583073d into HelpChat:main May 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kqliber Kqliber Kqliber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlitzOffline @Kqliber