-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#153] add footer login page #155
Draft
amirhraj
wants to merge
9
commits into
Hexlet:main
Choose a base branch
from
amirhraj:add_footer_branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+358
−119
Draft
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
22b70c0
[#153] add footer login page
amirhraj ed651dd
[#153 add footer in login and signup]
amirhraj 334be3c
[#153] add fotter
amirhraj cbb9ba4
[#153] add footer
amirhraj bd31505
[#153] fix footer class
amirhraj 5e6fca8
[#153] fix footer class
amirhraj 99819c7
[#153] fix footer class
amirhraj bd9ba88
[#153] add foooter fragments
amirhraj 97873b7
[#153] add layout fragments
amirhraj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,6 +84,6 @@ | |
| </div> | ||
| </div> | ||
| </main> | ||
|
|
||
| <footer th:replace="~{fragments/footer :: foot}"></footer> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en" xmlns:th="http://www.thymeleaf.org"> | ||
| <body> | ||
| <footer th:fragment="foot" class="footer fixed-bottom d-flex p-3 "> | ||
| <div class="container-xl"> | ||
| <div class="row justify-content-lg-around"> | ||
| <div class="col-sm-6 col-md-3 col-lg-auto"> | ||
| <a class="text-dark px-0 py-0 text-decoration-none " href="https://ru.hexlet.io"> | ||
| <p class="h3 mb-2 text-light">© Hexlet</p> | ||
| </a> | ||
| <ul class="nav flex-column"> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://sicp.hexlet.io/ru/pages/about"> | ||
| О проекте | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://github.com/Hexlet/hexlet-correction" | ||
| target="_blank"> | ||
| Исходный код | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://t.me/hexletcommunity/12" | ||
| target="_blank"> | ||
| Telegram Hexlet канал Волонтеры | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| <div class="col-sm-6 col-md-3 col-lg-auto"> | ||
| <p class="h5 mb-3">Помощь</p> | ||
| <ul class="nav flex-column"> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://ru.hexlet.io/blog"> | ||
| Блог | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://ru.hexlet.io/knowledge"> | ||
| База знаний | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" | ||
| href="https://ru.hexlet.io/pages/recommended-books"> | ||
| Рекомендуемые книги | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| <div class="col-sm-6 col-md-3 col-lg-auto"> | ||
| <p class="h5 mb-3">Другие open-source проекты</p> | ||
| <ul class="nav flex-column"> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://github.com/Hexlet/hexlet-cv"> | ||
| Хекслет-резюме | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://github.com/Hexlet/hexlet-editor"> | ||
| Хекслет-редактор | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://github.com/Hexlet/hexlet-friends"> | ||
| Друзья Хекслета | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| <div class="col-sm-6 col-md-3 col-lg-auto"> | ||
| <p class="h5 mb-3">Дополнительно</p> | ||
| <ul class="nav flex-column"> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://ru.code-basics.com/"> | ||
| Code Basics | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://codebattle.hexlet.io/"> | ||
| Кодбаттл | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <a class="nav-link px-0 py-1 text-light" href="https://guides.hexlet.io/"> | ||
| Гайды Хекслета | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </footer> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,7 @@ | |
| </div> | ||
| </div> | ||
| </main> | ||
| <footer th:replace="~{fragments/footer :: foot}"></footer> | ||
|
|
||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Футер должен быть не только на странице входа, но вообще любой, где пользователь сидит. К примеру такая логика на Хекслете, код бейзиксе (на хекслете футера нет только в практиках)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я почти везде добавил, чтобы посмотреть как это все выглядет и потыкать мы можем связаться в телеграм или еще где, я его у себя соберу и дам IP что бы смогли зайти посмотреть.