Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile and config file for Sphinx, nbsphinx (Add Sphinx docs - Part 3) #97

Closed
wants to merge 22 commits into from

Conversation

chmreid
Copy link
Collaborator

@chmreid chmreid commented Dec 19, 2019

Add files for building Sphinx docs. Incorporate nbsphinx into the Sphinx Makefile.

Closes #98

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@chmreid chmreid changed the title Chmreid add sphinx Add files for Sphinx and nbsphinx (Add Sphinx docs - Part 3) Dec 19, 2019
@chmreid chmreid changed the base branch from master to chmreid-sphinx-fix-notebooks December 19, 2019 22:14
@chmreid chmreid self-assigned this Dec 19, 2019
@chmreid chmreid changed the title Add files for Sphinx and nbsphinx (Add Sphinx docs - Part 3) Add Makefile and config file for Sphinx, nbsphinx (Add Sphinx docs - Part 3) Dec 19, 2019
@chmreid chmreid added this to the Q1 2020 Milestone 1 milestone Jan 7, 2020
chmreid and others added 11 commits January 9, 2020 09:22
* udpate install-hca nb

* update install-hca readme

* update text of intro nb cell in install-hca

* update index.rst to avoid conflict
* update find-cell-type-count nb

* update cell counts (WIP)

* add proper cell counts to find-cell-type-count nb

* update readme for find cell type count

* update index.rst to avoid conflict
* update explore-scanpy-may-2019

* update explore-scanpy nb with prod run

* replace 2 explore-hca-dataset-scanpy nbs with 1

* update readme and rename explore-hca-scanpy nb

* update index.rst to avoid conflict
* add new elasticsearch-queries notebook

* update elasticsearch-queries nb with prod results

* add a readme
* update download-smartseq2-matrix nb

* update smartseq2-matrix nb with prod results

* update readme

* update index.rst to avoid conflict
* update download-any-bam-file nb

* update download any bam file to use functions

* fix wording

* fix typo

* update readme description and link

* update index.rst to avoid conflict
* update download-all-fastq-files

* refactor functions in download-all-fastq-files nb

* fix a function

* update readme

* update index.rst to avoid conflict
* mv download-10x-seq-tcell to download-10x-liver

* update name of 10x-liver nb in index

* add examples of downloading 10x-liver data

* remove old 10x-seq-tcell nb dir

* add 10x-liver readme

* update index.rst to avoid conflict
@chmreid
Copy link
Collaborator Author

chmreid commented Jan 9, 2020

CI/CD system is failing on running treon tests on the explore scanpy notebook. The failure is caused by a typing system issue when using scanpy to create a tSNE plot. This type error is an artifact of changes to typing system in Python. The treon tests pass using Python 3.6.3 but do not pass using Python 3.6.9 or 3.7+.

Looking into a fix now...

@chmreid
Copy link
Collaborator Author

chmreid commented Jan 9, 2020

Fix was to pin scanpy version to be 1.3.*

@chmreid chmreid closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant