-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
named parameters in up.sh; saving trajectories; trajectories replay #29
base: master
Are you sure you want to change the base?
named parameters in up.sh; saving trajectories; trajectories replay #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Thanks for adding this long-awaited feature! LGTM but would like to get feedback from @nathan-miller23
I have cloned this branch and tested it locally. It does indeed work
@bmielnicki just one more question, is this supposed to work with the trajectory visualization PR? |
Currently, there is no integration between this PR and HumanCompatibleAI/overcooked_ai#38 except they use the same trajectory format. I plan to get them both working together - when the player picks the trajectory file to visualize he will be able to see both the replay and the chart. |
Additional changes are pushed:
Next step:
As before - this change is ready to be merged after getting feedback. |
Extension of this PR is #30 It is separate PR because it requires review of HumanCompatibleAI/overcooked_ai#38 and I don't want to prevent merge of previous changes because of that. |
I plan to add additional stuff into this branch (like replaying trajectories from trajectory directory), but changes above seems to be mergable into master now.