Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNS - IMD #110

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

SNS - IMD #110

wants to merge 11 commits into from

Conversation

sa-fx
Copy link
Contributor

@sa-fx sa-fx commented Mar 27, 2023 •
edited
Loading

IMD requirements

  • Retrieve the isolation status from the IMD
  • Retrieve real-time values for resistance between the positive power supply terminal and the chassis, and the negative power supply terminal and the chassis

@sa-fx sa-fx added the sensors Sensors Project label Mar 27, 2023
@sa-fx sa-fx self-assigned this Mar 27, 2023
maxguy2001
maxguy2001 requested changes Mar 29, 2023
View reviewed changes
lib/debug/repl.cpp Outdated Show resolved Hide resolved
test/core/CMakeLists.txt Outdated Show resolved Hide resolved
TomLonergan03
TomLonergan03 requested changes May 29, 2023
View reviewed changes
Copy link
Contributor

@TomLonergan03 TomLonergan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should get it to build once you fix these issues, my bad on the can.hpp id type

lib/sensors/imd_processor.cpp Outdated Show resolved Hide resolved
lib/sensors/imd.cpp Outdated Show resolved Hide resolved
lib/sensors/imd.hpp Outdated Show resolved Hide resolved
lib/sensors/imd.hpp Show resolved Hide resolved
lib/sensors/imd.cpp Outdated Show resolved Hide resolved
lib/sensors/imd.hpp Outdated Show resolved Hide resolved
@sa-fx sa-fx marked this pull request as ready for review May 29, 2023 20:06
@sa-fx sa-fx requested review from SnickeyX and kshxtij as code owners May 29, 2023 20:06
TomLonergan03
TomLonergan03 requested changes May 29, 2023
View reviewed changes
Copy link
Contributor

@TomLonergan03 TomLonergan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more things then good to go

lib/debug/repl.hpp Outdated Show resolved Hide resolved
lib/sensors/imd.hpp Outdated Show resolved Hide resolved
@sa-fx sa-fx requested a review from maxguy2001 May 30, 2023 08:07
maxguy2001
maxguy2001 requested changes May 30, 2023
View reviewed changes
lib/sensors/imd.hpp Show resolved Hide resolved
lib/sensors/imd.cpp Outdated Show resolved Hide resolved
lib/sensors/imd.cpp Outdated Show resolved Hide resolved
@sa-fx sa-fx requested a review from maxguy2001 May 30, 2023 20:56
@sa-fx sa-fx removed their assignment May 30, 2023
maxguy2001
maxguy2001 requested changes May 30, 2023
View reviewed changes
Copy link
Member

@maxguy2001 maxguy2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny style guide thing but otherwise good to go

lib/sensors/imd.cpp Outdated Show resolved Hide resolved
@sa-fx sa-fx requested a review from maxguy2001 May 31, 2023 08:37
SnickeyX
SnickeyX approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@SnickeyX SnickeyX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes, otherwise hope it gets tested

lib/debug/repl.cpp Show resolved Hide resolved
lib/debug/repl.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomLonergan03 TomLonergan03 TomLonergan03 approved these changes

@SnickeyX SnickeyX SnickeyX approved these changes

@maxguy2001 maxguy2001 maxguy2001 approved these changes

@kshxtij kshxtij Awaiting requested review from kshxtij kshxtij is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
sensors Sensors Project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sa-fx @TomLonergan03 @maxguy2001 @SnickeyX