Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowercase project and account name, update readme, update zip log message #12

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Lowercase project and account name, update readme, update zip log message #12

merged 7 commits into from
Mar 15, 2024

Conversation

BrettCleary
Copy link
Contributor

This PR

  • lowercases all account and project names passed as all on chain values are lowercased
  • updates the readme with the updated YML structure and other details addressing commonly asked questions by developers. Adds FAQ
  • logs the file zip instead of the path passed in which could be . and causes the log message to be zipping.... which is confusing
  • bumps 2.10.2

@BrettCleary BrettCleary requested a review from jiyuu-jin March 15, 2024 04:55
@BrettCleary BrettCleary self-assigned this Mar 15, 2024
jiyuu-jin
jiyuu-jin approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@jiyuu-jin jiyuu-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@BrettCleary BrettCleary merged commit c01fc15 into main Mar 15, 2024
1 check passed
@BrettCleary BrettCleary deleted the fixes branch March 15, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyuu-jin jiyuu-jin jiyuu-jin approved these changes

Assignees

@BrettCleary BrettCleary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettCleary @jiyuu-jin