Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CD] Add skip hp publish flag #6

Merged
merged 2 commits into from
Mar 8, 2024
Merged

[CD] Add skip hp publish flag #6

merged 2 commits into from
Mar 8, 2024

Conversation

BrettCleary
Copy link
Contributor

For HP desktop client and IPDT, I believe we just want to publish them to valist and not submit them for HyperPlay store review on every release.

I've added a flag skip_hyperplay_publish to skip the HyperPlay publishing step in this case.

@BrettCleary BrettCleary requested a review from jiyuu-jin March 8, 2024 09:20
@BrettCleary BrettCleary self-assigned this Mar 8, 2024
jiyuu-jin
jiyuu-jin approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@jiyuu-jin jiyuu-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/flags.ts Outdated Show resolved Hide resolved
Base automatically changed from ci/add_tests to main March 8, 2024 20:48
@BrettCleary BrettCleary merged commit d9e979b into main Mar 8, 2024
1 check passed
@BrettCleary BrettCleary deleted the cd/add_skip_hp branch March 8, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyuu-jin jiyuu-jin jiyuu-jin approved these changes

Assignees

@BrettCleary BrettCleary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettCleary @jiyuu-jin