Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Extract Progress for Base Game #1127

Merged
merged 3 commits into from
Nov 1, 2024
Merged

[FIX] Extract Progress for Base Game #1127

merged 3 commits into from
Nov 1, 2024

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented Oct 23, 2024 •
edited
Loading

Fixed a regression introduced on my previous PR #1095 that was causing the total size of the Base game for market wars broken.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima self-assigned this Oct 23, 2024
@flavioislima flavioislima added the PR: Ready-For-Review PR is ready to be reviewed by peers label Oct 23, 2024
jiyuu-jin
jiyuu-jin approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@jiyuu-jin jiyuu-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Oct 28, 2024
nyghtstalker
nyghtstalker approved these changes Oct 29, 2024
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the ETA is now matching in the install modal and downloads page for downloading and extraction.

image
image

@BrettCleary BrettCleary merged commit b7c2ad5 into main Nov 1, 2024
10 checks passed
@BrettCleary BrettCleary deleted the fix/mw_extract branch November 1, 2024 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@BrettCleary BrettCleary BrettCleary approved these changes

@jiyuu-jin jiyuu-jin jiyuu-jin approved these changes

@eliobricenov eliobricenov Awaiting requested review from eliobricenov

Assignees

@flavioislima flavioislima

Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flavioislima @jiyuu-jin @BrettCleary @nyghtstalker