-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Refactor package.json, electron builder and others #1180
Open
flavioislima
wants to merge
19
commits into
main
Choose a base branch
from
tech/elec_build_yml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…desktop-client into tech/elec_build_yml
…desktop-client into tech/elec_build_yml
flavioislima
changed the title
Tech/elec build yml
[TECH] Refactor package.json, electron builder and others
Jan 9, 2025
flavioislima
force-pushed
the
tech/elec_build_yml
branch
from
January 13, 2025 20:48
4eef34d
to
c1b5e23
Compare
flavioislima
force-pushed
the
tech/elec_build_yml
branch
from
January 13, 2025 20:50
c1b5e23
to
76fc6f6
Compare
…nstall additional dependencies
…ming/hyperplay-desktop-client into tech/elec_build_yml
…desktop-client into tech/elec_build_yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several important changes to the project's configuration and build process, particularly focusing on the
electron-builder
configuration and thepackage.json
scripts. Below are the most significant changes:Build Configuration:
electron-builder.yml
file to configure the Electron build process..Project Configuration:
build
section frompackage.json
and moved its content to the newelectron-builder.yml
file.Scripts:
scripts
section inpackage.json
to be above thedependencies
.Email Update:
package.json
from[email protected]
to[email protected]
.ESLint Ignore:
.eslintignore
to include additional directories such asbuild
,dist
, andplaywright-report
.Use the following Checklist if you have changed something on the Backend or Frontend: