Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/release workflows #1198

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fix/release workflows #1198

merged 3 commits into from
Dec 19, 2024

Conversation

BrettCleary
Copy link
Collaborator

Summary

release mac is failing with

Error: Multiple versions of pnpm specified:
    - version 9 in the GitHub Action config with the key "version"
    - version [email protected]+sha1.a428b12[20](https://github.com/HyperPlay-Gaming/hyperplay-desktop-client/actions/runs/12405297238/job/34631892388#step:4:21)2bc4f23b17e6dffe730734dae5728e2 in the package.json with the key "packageManager"
  Remove one of these versions to avoid version mismatch errors like ERR_PNPM_BAD_PM_VERSION

So let's update to v9 in package.json

Also bumps cache GHA to v4 as v2 is deprecated

Testing

Going to tag this branch to test the workflows before merging

@BrettCleary BrettCleary self-assigned this Dec 19, 2024
@BrettCleary BrettCleary merged commit 0052e2b into main Dec 19, 2024
11 of 16 checks passed
@BrettCleary BrettCleary deleted the fix/release_workflows branch December 19, 2024 03:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@BrettCleary BrettCleary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BrettCleary