-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Improve Download Toast #558
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-game-dev
force-pushed
the
ux/improve_download_toast
branch
from
October 24, 2023 17:19
2c249d1
to
5ba4bd8
Compare
…ially does not start from 0
…l, resume, pause yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Use the following Checklist if you have changed something on the Backend or Frontend:
🐛 Issue Addressed
Linked Issue: Install modal does not display extracting - PR Main issue
Linked Issue: Disk space check does not account for extraction space
✅ Other Fixed Issues
🚀 Props API Update for Components
inExtraction
DownloadToast
with a newdownloadStatus
type: 'inExtraction'☕ New PCI Handlers
📌 PR Blocked From Issue Below
HyperPlay-Gaming/hyperplay-ui#101
🗺️ Approach Taken
Our aim is to start using classes because we have a lot of code that is intertwined and makes debugging, fixing, or enhancing the code time-consuming. For instance, we have developed an
ExtractZipService
class that handles zip extraction-related functionalities, including the decompressed total bytes for later use. Our approach enables us to test the class independently, providing us with a better guarantee that everything is working as expected. Additionally, we always apply the SOC Principle, which helps us avoid days of debugging. 🙌🛠️ Testing Steps
Before diving in, ensure you have access to both
hyperplay-ui
andhyplerplay-store
repositories.hyperplay-ui
:hyperplay-ui
:hyperplay-ui
tohyperplay-desktop-client
:Megaweapon
> Add to Libraryestimated
)Please make sure to test all the following, please feel free to edit the PR readme in case there are more ways we should test
Pages
Toast, Download Bar on Game Card, Game Actions on Download Manager, Buttons on Game Page (Cancel Extraction, Cancel Download, etc)
UI
📣 Important Note
This fix pinpoints where pause, resume are generally controlled by a status on
hyperplay-ui
lib, which we had to add. Once we're all aligned, let's ensure topackage.json
ofhyperplay-ui
will be needed, with the latest update