Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Launch of sideloaded browser games #609

Merged
merged 1 commit into from
Oct 27, 2023
Merged

[Fix] Launch of sideloaded browser games #609

merged 1 commit into from
Oct 27, 2023

Conversation

BrettCleary
Copy link
Collaborator

Fixes launching sideloaded browser games

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@BrettCleary BrettCleary added PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA labels Oct 26, 2023
@BrettCleary BrettCleary self-assigned this Oct 26, 2023
nyghtstalker
nyghtstalker approved these changes Oct 26, 2023
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed we can now launch sideloaded browser games.

@leon-do
Copy link
Contributor

leon-do commented Oct 26, 2023

lgtm

@BrettCleary BrettCleary merged commit 599f9fe into main Oct 27, 2023
16 checks passed
@BrettCleary BrettCleary deleted the fix/sideloaded_browser_launch branch October 27, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@eliobricenov eliobricenov eliobricenov approved these changes

@flavioislima flavioislima flavioislima approved these changes

Assignees

@BrettCleary BrettCleary

Labels
PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BrettCleary @leon-do @flavioislima @eliobricenov @nyghtstalker