[Tech] add cta component, hide eligibility and hide claim props #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BrettCleary
commented
Dec 4, 2024
| @@ -63,13 +67,6 @@ export function QuestDetailsWrapper(props: QuestDetailsWrapperProps) { | |||
| const questResult = useGetQuest(selectedQuestId, getQuest) | |||
| const questMeta = questResult.data?.data | |||
|
|
|||
| const rewardsQuery = useGetRewards({ | |||
There was a problem hiding this comment.
not being used anywhere
BrettCleary
commented
Dec 4, 2024
| @@ -9,7 +9,7 @@ export default defineConfig({ | |||
| publicDir: 'public', | |||
| resolve: { | |||
| alias: { | |||
| '@': '/src' | |||
| '@': join(__dirname, 'src') | |||
There was a problem hiding this comment.
dist/components/QuestDetailsWrapper/index.d.ts was building the @/types/quests into ../../../../../../src/types/quests
This now matches what we have in the desktop client and the QuestWrapperContextValue type works now
There was a problem hiding this comment.
niiiiice, this is the fix I was looking for but couldn't get
eliobricenov
approved these changes
Dec 5, 2024
BrettCleary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/HyperPlay-Gaming/product-management/issues/791