[Feat] Update getPlaystreakQuestStatus to hide if ineligible completed quest #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -23,6 +23,8 @@ export function getPlaystreakQuestStatus( | |||
| (gameIsInfinitelyCompleteable || gameHasMoreFiniteCompletionsPossible) | |||
| ) { | |||
| return 'READY_FOR_CLAIM' | |||
| } else if (quest.status === 'COMPLETED') { | |||
| return undefined | |||
There was a problem hiding this comment.
Why undefined instead of addind another option to the type? I find a value like NOT_QUALIFIED better than the absence of value.
There was a problem hiding this comment.
I didn't want it to be confused with a QuestLogInfo['state'] value. undefined in this case means the quest shouldn't be shown to the user.
I do see where your coming from and would make the change if I weren't under a bit of a time crunch. This is a bit of a nitpick though
jiyuu-jin
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/HyperPlay-Gaming/product-management/issues/531
used in HyperPlay-Gaming/hyperplay-desktop-client#1183