Make sure the code really generates the PAGE_SIZE specified. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line start_new_page size: PAGE_SIZE, layout: :portrait, margin: margin does indeed set the page size for a new page. However, the initial Prawn::Document.generate call determines the default settings for the entire document, including the page size for the first page. If the start_new_page method is used later in the code (after the first page has already been created with the default settings), it will apply the PAGE_SIZE setting to the new pages added after the initial page. This means the first page would still be in the default size (LETTER), while subsequent pages would be in A4 size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line start_new_page size: PAGE_SIZE, layout: :portrait, margin: margin does indeed set the page size for a new page. However, the initial Prawn::Document.generate call determines the default settings for the entire document, including the page size for the first page.
If the start_new_page method is used later in the code (after the first page has already been created with the default settings), it will apply the PAGE_SIZE setting to the new pages added after the initial page. This means the first page would still be in the default size (LETTER), while subsequent pages would be in A4 size.
One way to tell the page size is with the pdfinfo command line.