Enhance Navigation and Dashboard: Add Home Link and Interactive Tiles #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bahati308 Can you please review this pull request? |
mozzy11
reviewed
Jan 16, 2025
mozzy11
reviewed
Jan 17, 2025
| @@ -359,8 +359,23 @@ const HomeDashBoard: React.FC<DashBoardProps> = () => { | |||
| } | |||
| }; | |||
|
|
|||
| const handleTileClick = (tile) => { | |||
There was a problem hiding this comment.
By the way this function is an exact duplicate of this existing function handleMaximizeClick.
Why not just use an existing function instead of duplicating it ??
There was a problem hiding this comment.
@mozzy11 I thought I should create two separate function to be called on an onClick event on different components... Anyways I will modify the code to use the existing function and push the changes... Thank You for you feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: issue#1399
Summary
This pull request addresses issues related to navigation and dashboard functionality by implementing the following improvements:
Screen-recording
Screencast.from.14-01-25.23.09.08.webm
Related Issue
#1399