Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lab 1 and 2 to granite 3.1 #40

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Update lab 1 and 2 to granite 3.1 #40

merged 1 commit into from
Jan 14, 2025

Conversation

bjhargrave
Copy link
Member

No description provided.

Copy link
Member

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, thanks @bjhargrave.

It looks good apart from the error with function call in RAG notebook (comment inline).

Also, it might be worth adding a note to Populate the vector database section as this cell can fail intermittingly for no obvious reason and re-running it fixes the issue.

notebooks/RAG_with_Langchain.ipynb Show resolved Hide resolved
Copy link
Member

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bjhargrave

@hickeyma hickeyma merged commit b37d416 into main Jan 14, 2025
12 checks passed
@hickeyma hickeyma deleted the granite-3.1 branch January 14, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants