-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use replace_resource only if resource already exists #111
Conversation
Signed-off-by: knatsu-summer <[email protected]>
1728acb
to
ef02f7c
Compare
Signed-off-by: knatsu-summer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! It looks like we need to get the other unit tests passing before merging
Signed-off-by: knatsu-summer <[email protected]>
@gabe-l-hart @HonakerM
I tested it locally and added some log prints., it seems that the resource is not being updated after
The values of
I tried |
Signed-off-by: knatsu-summer <[email protected]>
Signed-off-by: knatsu-summer <[email protected]>
The update body was accidentally being discarded in favor of the current cluster state. Branch: deploymeshod_replace Signed-off-by: Gabe Goodhart <[email protected]>
@knatsu-summer this found a pretty gnarly bug in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the fix in kub_mock
, this should be good to go!
Related Issue
Supports #ISSUE_NUMBER
Related PRs
This PR is not dependent on any other PR
What this PR does / why we need it
Encountering a 404 error when user uses
_replace_resource
option to deploy a resource that is not currently in the environment.I would like to add logic to use
_apply_resource
instead of_replace_resource
when first deploying.Special notes for your reviewer
If applicable**
What gif most accurately describes how I feel towards this PR?