Library port #8
Merged
Library port #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-l-hart
force-pushed
the
LibraryPort
branch
2 times, most recently
from
d26aca5 to
84ad8b7
Compare
|
@gabe-l-hart I'm excited for this PR! Lmk if/when you'd like a review |
gabe-l-hart
force-pushed
the
LibraryPort
branch
3 times, most recently
from
e49391d to
fd9764c
Compare
|
@HonakerM Thanks! I think I finally have the build working, it would be great to get your review. |
HonakerM
reviewed
Nov 20, 2023
| @@ -0,0 +1,20 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
There was a problem hiding this comment.
Do we want to regen this cert to not use ibm.com?
.github/workflows/build-library.yml
Outdated
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Set up Python ${{ matrix.python-version.setup }} | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: ${{ matrix.python-version.setup }} | ||
| - name: Set up Node |
There was a problem hiding this comment.
Why do we still need node? I thought all of the cdk8s references were removed?
HonakerM
approved these changes
Nov 20, 2023
This will get re-enabled after the initial port Signed-off-by: Gabe Goodhart <[email protected]>
Co-authored-by: Hanna Yang <[email protected]> Co-authored-by: Jaymin Desai <[email protected]> Co-authored-by: Casey Honaker <[email protected]> Co-authored-by: Michael Barlock <[email protected]> Co-authored-by: Charles De Saint-Aignan <[email protected]> Co-authored-by: Ryo Imai <[email protected]> Co-authored-by: Jia Xin Gao <[email protected]> Co-authored-by: Kinson Chik <[email protected]> Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
This appears to be the current default branch name for the version of git available on the GH Actions runner Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
This is needed to get the k8s mixin correctly Signed-off-by: Gabe Goodhart <[email protected]>
They were primarily residual in the test helpers which are no longer needed Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
gabe-l-hart
force-pushed
the
LibraryPort
branch
from
86f296f to
68584bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR ports the internal code project!
Special notes for your reviewer
This PR disables linting so that the code can be ported as-is. A follow-on PR will fix all linting errors and re-enable
What gif most accurately describes how I feel towards this PR?