Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about data sent to IBM services in help #173

Closed

Conversation

kevinrobinson
Copy link

This is trying to help out with #172.

@dalelane As a first step, this updates the help in the bit I discovered looking at recognizing text, and IBM Watson Assistant. I tried to run the app locally to grab a proper screenshot for ya but I don't have accounts for all the dependencies like Auth0 or Watson so wasn't sure what to do there. Hopefully I've followed your example and this work just like it appears :)

@dalelane
Copy link
Member

Thanks very much for this. I'm super-busy this week, so will review/merge over the weekend.

@ajdaniel
Copy link
Contributor

This looks like a good start to address any questions kids, parents or teachers may have around privacy in the site.

Updating it to be a new question, rather than a continuation
of the previous question.
@dalelane
Copy link
Member

Thanks for this. Sorry, but there are a few things I'd like to change about this, so I'll start a new pull request to put it in - as I don't have access to your fork.

@dalelane dalelane closed this Mar 25, 2019
@kevinrobinson
Copy link
Author

@dalelane no worries, sounds good!

@dalelane
Copy link
Member

dalelane commented Mar 25, 2019

Added it in 4210e67#diff-11d846e5bf303f1b6b753af028939c24

The main differences:

  • Added it to all language files, not just the English file (that is useful for translators so they only have one place to look for what needs translating, rather than needing to keep the different language files in sync themselves - it also means the build passes, as there are automated tests at build time which make sure that there is nothing in any one NLS file that is missing from any other language NLS files)
  • Added Visual Recognition links as well as Watson Assistant - to cover both image and text projects (I think that for some parents/teachers, they may have more concern about image training data than for text training, as this could contain photos of the children themselves if they use webcams to collect training images - so I wanted to make sure both were included)
  • Added a clarification that as the DB administrator, I have access to all the raw data, but that I don't allow others to access it and won't share/publish it
  • Modified the HTML to split it out into it's own question rather than having it run-on from the user info question

@kevinrobinson
Copy link
Author

@dalelane This looks awesome, and much better than my attempt! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants