fixed an issue where auto suggestion and mouse hover on port validati…

…on were inconsistent
ICRAR · Jul 26, 2024 · 36aef94 · 36aef94
1 parent b694f7b
commit 36aef94
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Edge.ts b/src/Edge.ts
@@ -499,6 +499,12 @@ export class Edge {
             if(sourceNode.isApplication() && destinationNode.isApplication()){
                 draggingEdgeFixable = true
             }
+
+            if(sourcePort.isInputPort() && destinationPort.isInputPort() && !destinationPort.isOutputPort()){
+                impossibleEdge = true
+            }else if (sourcePort.isOutputPort() && destinationPort.isOutputPort() && !destinationPort.isInputPort()){
+                impossibleEdge = true
+            }
         }
 
         //the worst edge errror function can only check for entries in errors or warnings, it isnt able to distinguish impossible from invalid

diff --git a/src/GraphRenderer.ts b/src/GraphRenderer.ts
@@ -2129,8 +2129,13 @@ export class GraphRenderer {
             }
             return
         }
+        let isValid: Errors.Validity
 
-        const isValid = Edge.isValid(eagle, true, null, GraphRenderer.portDragSourceNode().getKey(), GraphRenderer.portDragSourcePort().getId(), GraphRenderer.destinationNode.getKey(), GraphRenderer.destinationPort.getId(), false, false, false, false, {errors:[], warnings:[]});
+        if(!GraphRenderer.portDragSourcePortIsInput){
+            isValid = Edge.isValid(eagle, true, "", GraphRenderer.portDragSourceNode().getKey(), GraphRenderer.portDragSourcePort().getId(), GraphRenderer.destinationNode.getKey(), GraphRenderer.destinationPort.getId(), false, false, false, false, {errors:[], warnings:[]});
+        }else{
+            isValid = Edge.isValid(eagle, true, "", GraphRenderer.destinationNode.getKey(), GraphRenderer.destinationPort.getId(), GraphRenderer.portDragSourceNode().getKey(), GraphRenderer.portDragSourcePort().getId(), false, false, false, false, {errors:[], warnings:[]});
+        }
         GraphRenderer.isDraggingPortValid(isValid);
     }