EAGLE-1263: Add undo snapshot after adding edge between two nodes #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request implements an undo snapshot feature in the GraphRenderer class. Specifically, after an edge is added between two nodes, a snapshot is pushed to the undo stack with a descriptive message. This ensures that the action can be undone if necessary. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @james-strauss-uwa - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -2144,6 +2144,7 @@ export class GraphRenderer { | |||
|
|
|||
| eagle.addEdge(srcNode, srcPort, destNode, destPort, loopAware, closesLoop, (edge : Edge) : void => { | |||
| eagle.checkGraph(); | |||
| eagle.undo().pushSnapshot(eagle, "Added edge from " + srcNode.getName() + " to " + destNode.getName()); | |||
There was a problem hiding this comment.
suggestion: Consider using template literals for string concatenation.
Using template literals can make the string concatenation more readable and maintainable. For example: Added edge from ${srcNode.getName()} to ${destNode.getName()}.
Suggested change
| eagle.undo().pushSnapshot(eagle, "Added edge from " + srcNode.getName() + " to " + destNode.getName()); | |
| eagle.undo().pushSnapshot(eagle, `Added edge from ${srcNode.getName()} to ${destNode.getName()}`); |
M-Wicenec
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request introduces a new feature that creates an undo snapshot whenever an edge is added between two nodes in the graph. This ensures that users can revert the action if needed.