-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-naming 'parameter_table' to 'node_parameter_table' #809
Conversation
Reviewer's Guide by SourceryThis PR renames the 'ParameterTable' and 'GraphConfigAttributesTable' modes to 'NodeParameterTable' and 'ConfigParameterTable' respectively throughout the codebase. The changes are primarily focused on updating references to these modes in various files while maintaining the existing functionality. Class diagram for the updated ParameterTableclassDiagram
class ParameterTable {
+getDisplayText()
+selection()
+openTable(mode: Eagle.BottomWindowMode, selectType: ParameterTable.SelectType)
+toggleTable(mode: Eagle.BottomWindowMode, selectType: ParameterTable.SelectType)
+getNodeLockedState(field: Field) : boolean
}
class Eagle {
Eagle.BottomWindowMode NodeParameterTable
Eagle.BottomWindowMode ConfigParameterTable
}
ParameterTable --> Eagle: uses
note for ParameterTable "Renamed modes to NodeParameterTable and ConfigParameterTable"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @M-Wicenec - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
templates/base.html
Outdated
@@ -206,10 +206,10 @@ | |||
</div> | |||
<div class="content"> | |||
<!-- ko if: $root.getEagleIsReady() --> | |||
<!-- ko if: Setting.findValue(Setting.BOTTOM_WINDOW_MODE) === Eagle.BottomWindowMode.ParameterTable --> | |||
<!-- ko if: Setting.findValue(Setting.BOTTOM_WINDOW_MODE) === Eagle.BottomWindowMode.NodeParameterTable --> | |||
{% include 'parameter_table.html' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a new file called node_parameter_table.html
in this PR. But the code seems to still be including the old file parameter_table.html
.
i looked at all the mentions of 'parameterTable' and it seems like just about all of them are either shared classes for the css, or referencing a function inside of the shared 'parameterTable.ts' file.
ive Renamed the file for the node parameter, tooltips that mention it and enums for the node parameter table
Summary by Sourcery
Enhancements: