Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagle 1371 #811

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Eagle 1371 #811

merged 10 commits into from
Jan 13, 2025

Conversation

M-Wicenec
Copy link
Collaborator

@M-Wicenec M-Wicenec commented Dec 19, 2024

made a new icon to represent the overwriting of the graph's value by the config value
added a hidden setting to be able to toggle the display of both values
made the config value more distinct

Summary by Sourcery

Add a new icon for overwriting graph values and a hidden setting to toggle dual value display. Enhance the parameter table to make config values more distinct.

New Features:

  • Introduce a new icon to represent the overwriting of the graph's value by the config value.
  • Add a hidden setting to toggle the display of both the graph's value and the config value.

Enhancements:

  • Make the config value more distinct in the parameter table display.

Copy link
Contributor

sourcery-ai bot commented Dec 19, 2024

Reviewer's Guide by Sourcery

This PR implements a new dual-value display feature in the node parameter table, allowing users to toggle between showing both the configured value and graph value simultaneously or just the active value. The implementation includes a new icon for representing value overwriting, styling updates for better visual distinction between configured and graph values, and a hidden setting to control this feature.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new toggle feature for dual-value display in the node parameter table
  • Added a toggle button in the value column header
  • Implemented conditional rendering of single/dual value displays
  • Added a new hidden setting NODE_PARAMS_TABLE_DUAL_VALUE_DISPLAY to control the feature
templates/node_parameter_table.html
src/Setting.ts
Created and integrated a new overwrite icon for better visual representation
  • Added new overwrite icon to the icon font set
  • Replaced the material-icons arrow with the new custom overwrite icon
  • Updated font file references with new version
static/fonts.css
static/fonts/icomoon.svg
resources/overwrite.svg
Enhanced styling for better visual distinction between configured and graph values
  • Updated border styles for configured values
  • Added specific styling for the dual-value display toggle button
  • Adjusted spacing and sizing for the new layout
static/tables.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @M-Wicenec - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@M-Wicenec M-Wicenec merged commit 6a2f6ac into master Jan 13, 2025
1 check passed
@M-Wicenec M-Wicenec deleted the eagle-1371 branch January 13, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant