-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eagle 1371 #811
Eagle 1371 #811
Conversation
Reviewer's Guide by SourceryThis PR implements a new dual-value display feature in the node parameter table, allowing users to toggle between showing both the configured value and graph value simultaneously or just the active value. The implementation includes a new icon for representing value overwriting, styling updates for better visual distinction between configured and graph values, and a hidden setting to control this feature. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @M-Wicenec - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
made a new icon to represent the overwriting of the graph's value by the config value
added a hidden setting to be able to toggle the display of both values
made the config value more distinct
Summary by Sourcery
Add a new icon for overwriting graph values and a hidden setting to toggle dual value display. Enhance the parameter table to make config values more distinct.
New Features:
Enhancements: