Add CORS headers to index URL used in URL check.

[myxie]

Issue

We have had problems with Chrome and Opera regarding the URL check that occurs when we use the deploy button, which appear to be related to CORS errors being reported:

This is likely caused by the check getting the HEAD of the dim.html page, which is served with a bottle template response that does not have CORS headers added (as opposed to all the URL end points attached to the Bottle app).

Solution

I have used our existing @daliuge_aware decorator to ensure that we add CORS headers to the template response when doing the check.

Summary by Sourcery

This pull request addresses CORS errors encountered in Chrome and Opera by adding CORS headers to the 'dim.html' page response using the existing '@daliuge_aware' decorator.

• Bug Fixes:
  • Added CORS headers to the 'dim.html' page response to resolve CORS errors in Chrome and Opera during URL checks.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses CORS issues in Chrome and Opera by adding CORS headers to the visualizeDIM method in the daliuge-engine/dlg/manager/rest.py file. This is achieved by applying the existing @daliuge_aware decorator to the method, ensuring that the template response includes the necessary CORS headers.

File-Level Changes

Files	Changes
daliuge-engine/dlg/manager/rest.py	Added CORS headers to the visualizeDIM method by using the @daliuge_aware decorator.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @myxie - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion: Clarify the purpose of the note in the docstring.

The note in the docstring is useful, but it might be clearer if it specifies why CORS headers are necessary for this method. For example, is it because this method is expected to be called from a web client?

Suggested change

	Note: this is marked as 'daliuge_aware' in order to get the CORS headers.
	Note: this is marked as 'daliuge_aware' in order to get the CORS headers.
	This is necessary because this method is expected to be called from a web client.

[myxie]

I am going to merge this as the failing tests are due to the recent numpy version update. This should be resolved by removing plasma from the code base LIU-390 which will follow this PR.

[coveralls]

coverage: 79.479% (+0.001%) from 79.478%
when pulling eba5bd3 on fix_cors_issue
into a055a77 on master.