-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) LIU-392: Enable per-port serailisation #300
Draft
myxie
wants to merge
3
commits into
master
Choose a base branch
from
LIU-392
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR implements per-port serialization by refactoring how input and output ports are handled in the Python function application. The changes modify the port argument processing to work directly with drops instead of pre-loading all input data, enabling more efficient handling of large datasets and providing better control over data serialization. Class diagram for updated port handling in Python function applicationclassDiagram
class PyFunc {
- _inputs
- _outputs
- parameters
- fn_nargs
- fn_nkw
- argnames
- input_parser
- output_parser
+ _ports2args(inputs, outputs, posargs, pargsDict, keyargsDict) dict
+ run()
}
note for PyFunc "Refactored to handle per-port serialization and direct drop handling"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
myxie
changed the title
LIU-392: Enable per-port serailisation
(WIP) LIU-392: Enable per-port serailisation
Dec 6, 2024
This commit has established per-commit encoding, whilst also updating/clarifying/polishing some existing PyFunc and Translator code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t values.
JIRA Ticket
LIU-392 (https://icrar.atlassian.net/browse/LIU-392)
Type
Problem/Issue
Solution
Checklist
Summary by Sourcery
Enable per-port serialization and refactor input/output port handling for improved clarity.
New Features:
Enhancements: