-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIU-439: Use translator avahi approach for engine. #302
base: master
Are you sure you want to change the base?
Conversation
Also added quickstart for README.rst to help people get started ASAP, based on user feedback.
Reviewer's Guide by SourceryThis pull request fixes an issue with the dlg-engine address resolution by using the translator avahi approach. It also adds a quickstart guide to the README. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @myxie - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a basic smoke test to verify hostname resolution works correctly after container startup. This would help validate the avahi-daemon changes across different environments.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sourcery updates. Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@@ -5,10 +5,16 @@ FROM icrar/daliuge-common:${VCS_TAG:-latest} | |||
# RUN sudo apt-get update && sudo DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends tzdata \ | |||
# gcc g++ gdb casacore-dev clang-tidy-10 clang-tidy libboost1.71-all-dev libgsl-dev | |||
|
|||
RUN apt install -y git python3.9-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer support Python 3.8.
@awicenec may you please review these? The component palette test failures appear to be a result of an expired secret key/token for authentication. I don't have admin access to EAGLE-graph-repo so cannot make a new token. If you're able to make me an admin for that repository as well I can update the token. |
JIRA Ticket
LIU-439
Type
[ ] Feature (addition)[ ] Refactor (change)Problem/Issue
I have experienced unreliability with the use of dlg-engine as an address when running the docker files on Ubuntu machines. Previously (after spending a day wondering what had broken) this was chalked up to my Ubuntu 22.04 installation being a slightly broken, as @awicenec's and my personal popOS laptops were fine. However, @omaranwar85 also had issues using the host names as well when running on another Ubuntu system, so something was problematic.
Solution
It looks like sending
service avahi start
whilst avahi is already started causes issues. I have never had any issues with thedlg-trans
address resolving on the daliuge-translator docker container, and it turns out the Dockerfile stops theavahi-daemon
before starting it, which is not in the engine dockerfile. Copying the translator approach appears to resolve the resolution issues.Also added quickstart for README.rst to help people get started ASAP, based on user feedback.
Checklist
[ ] Unittests addedSummary by Sourcery
Update Dockerfiles to resolve engine address resolution issues and add a quickstart guide to the README.
Bug Fixes:
Documentation: