Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added --ignore-pullrequests option #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felipesabino
Copy link

Adding option for filtering pull requests from list of issues.

As Github API does not provide a way to filter the request for non-pull request issues, it had to be done filtering the response


https://developer.github.com/v3/issues/#list-issues-for-a-repository

Note: Every pull request is an issue, but not every issue is a pull request. If the issue is not a pull request, the response omits the pull_request attribute.

@valentinzberea
Copy link

You should keep the original tab characters. The diff would be easier to follow without the tabs being replaced.

@felipesabino felipesabino force-pushed the master branch 2 times, most recently from 87bd277 to 5bb7c82 Compare October 29, 2014 15:50
@felipesabino
Copy link
Author

@valentinzberea Just patched the commit to maintain the tab spaces...

Btw, you should consider adding both EditorConfig and Github's contribution guidelines to the project in order to reduce the need for this sort of patching in the future :)

@felipesabino
Copy link
Author

@valentinzberea any updates on this?

@valentinzberea
Copy link

I'd like to help @felipesabino but I'm not a project collaborator to merge your pull request nor to add contribution guidelines to the project.

@@ -54,7 +55,10 @@ def init_config():
arg_parser.add_argument('--ignore-comments', dest='ignore_comments', action='store_true', help="Do not import comments in the issue.")
arg_parser.add_argument('--ignore-milestone', dest='ignore_milestone', action='store_true', help="Do not import the milestone attached to the issue.")
arg_parser.add_argument('--ignore-labels', dest='ignore_labels', action='store_true', help="Do not import labels attached to the issue.")

arg_parser.add_argument('--ignore-pullrequests', dest='ignore_pullrequests', action='store_true', help="Do not import issues that are pull requests.")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need this on line 112:

config.set('settings', 'import-pullrequests', str(not args.ignore_pullrequests))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants