-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added --ignore-pullrequests option #34
base: master
Are you sure you want to change the base?
Conversation
You should keep the original |
87bd277
to
5bb7c82
Compare
@valentinzberea Just patched the commit to maintain the tab spaces... Btw, you should consider adding both EditorConfig and Github's contribution guidelines to the project in order to reduce the need for this sort of patching in the future :) |
@valentinzberea any updates on this? |
I'd like to help @felipesabino but I'm not a project collaborator to merge your pull request nor to add contribution guidelines to the project. |
@@ -54,7 +55,10 @@ def init_config(): | |||
arg_parser.add_argument('--ignore-comments', dest='ignore_comments', action='store_true', help="Do not import comments in the issue.") | |||
arg_parser.add_argument('--ignore-milestone', dest='ignore_milestone', action='store_true', help="Do not import the milestone attached to the issue.") | |||
arg_parser.add_argument('--ignore-labels', dest='ignore_labels', action='store_true', help="Do not import labels attached to the issue.") | |||
|
|||
arg_parser.add_argument('--ignore-pullrequests', dest='ignore_pullrequests', action='store_true', help="Do not import issues that are pull requests.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need this on line 112:
config.set('settings', 'import-pullrequests', str(not args.ignore_pullrequests))
Adding option for filtering pull requests from list of issues.
As Github API does not provide a way to filter the request for non-pull request issues, it had to be done filtering the response
https://developer.github.com/v3/issues/#list-issues-for-a-repository