21-development.md: support Windows Server #10287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
added
bug
oxzi
reviewed
Jan 10, 2025
doc/21-development.md
Outdated
Comment on lines
1739
to
1740
| 1. `Enable-WindowsOptionalFeature -FeatureName NetFx3ServerFeatures -Online` | ||
| (Windows Server only) |
There was a problem hiding this comment.
Windows Server only
If this is something which only applies to some versions of an operating system, it should be written before the command as otherwise half the people would blindly copy the command just to be confused why it won't work on their non-server operating system.
Al2Klimov
commented
Jan 10, 2025
| 1. `Enable-WindowsOptionalFeature -FeatureName "NetFx3" -Online` | ||
| 1. `Enable-WindowsOptionalFeature -FeatureName NetFx3ServerFeatures -Online` | ||
| (Windows Server only) | ||
| 2. `Enable-WindowsOptionalFeature -FeatureName NetFx3 -Online` | ||
| (reboot when asked!) |
There was a problem hiding this comment.
Isn't "(reboot when asked!)" also already not prominent enough then?
There was a problem hiding this comment.
Wouldn't say so. The Windows Server only thing is a precondition for the command, while reboot when asked follows from the command.
That OS need NetFx3ServerFeatures to be enabled before NetFx3.
Al2Klimov
force-pushed
the
Al2Klimov-patch-7
branch
from
7ff9d5e to
ab0f20d
Compare
oxzi
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That OS need NetFx3ServerFeatures to be enabled before NetFx3.