-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configura o ReplaySessionSampleRate do Sentry #300
base: main
Are you sure you want to change the base?
Conversation
…nto config-sentry-replay-samplerate
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughAs alterações no arquivo de configuração do Sentry introduzem uma nova variável Changes
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
sentry.client.config.ts (2)
6-6
: Adicione validação para o valor da taxa de amostragemO valor obtido através do
process.env["SENTRY_REPLAY_SAMPLE_RATE"]
deve ser validado para garantir que seja um número válido entre 0 e 1.Sugestão de implementação com validação:
-const sampleRate = parseFloat(process.env["SENTRY_REPLAY_SAMPLE_RATE"] || "0.1"); +const rawSampleRate = parseFloat(process.env["SENTRY_REPLAY_SAMPLE_RATE"] || "0.1"); +const sampleRate = isNaN(rawSampleRate) ? 0.1 : Math.max(0, Math.min(1, rawSampleRate));
21-21
: Atualize o comentário para refletir a taxa de amostragem configurávelA implementação está correta, mas o comentário acima da configuração ainda sugere uma taxa fixa de 10%, o que não reflete mais a realidade da implementação configurável.
Sugestão de atualização do comentário:
- // This sets the sample rate to be 10%. You may want this to be 100% while - // in development and sample at a lower rate in production + // The sample rate is configurable via SENTRY_REPLAY_SAMPLE_RATE environment variable. + // Default is 10% if not specified. Consider using 100% in development/preview + // environments and a lower rate in production.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
sentry.client.config.ts
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
Objetivos
Summary by CodeRabbit