Update library config #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janndriessen
force-pushed
the
task/library2
branch
from
5bb4416 to
290ae57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds type(did not work)moduleto package.json (to hopefully get rid of the SDK's export issues).npmignore(as it is not necessary, files in.gitignorewill be excluded by default and the/buildfolder will be added through package.json'sfiles)ES and CommonJS modules
The library/SDK had some issues with exports and so importing in ES and/or CommonJS modules. Now tsup is used to configure the building/exporting.
Since ES is the future and mostly used nowadays, I tried to just add
type: modulein package.json but this won't work with hardhat: https://hardhat.org/hardhat-runner/docs/advanced/using-esm#esm-and-typescript-projects. And looks like it won't change anytime soon: NomicFoundation/hardhat#3385Temporarily disabling some integration tests for dsETH. They do work individually and locally but are to unreliable right now due to market quotes.