Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1566 storybook consistency and UI enhancement #1640

Open
wants to merge 167 commits into
base: master
Choose a base branch
from

Conversation

evangeliaPanteliadou
Copy link
Collaborator

@evangeliaPanteliadou evangeliaPanteliadou commented Dec 10, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

Storybook: consistency and UI enhancement #1566

📦 Published PR as canary version: 30.9.3--canary.1640.cca6b3e0f7f750f15c51f9cb6eb2c66789549fb3.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@30.9.3--canary.1640.cca6b3e0f7f750f15c51f9cb6eb2c66789549fb3.0
# or 
yarn add @infineon/infineon-design-system-stencil@30.9.3--canary.1640.cca6b3e0f7f750f15c51f9cb6eb2c66789549fb3.0

agata-kim and others added 30 commits November 14, 2024 16:25
…s. Fixed bug with inverted spinner in Spinner component.
@fapfaff
Copy link

fapfaff commented Jan 9, 2025

Looks already way better than before!
But here are a few things that I still would change:

Accordion

  • mutable: Improve description

Card

  • alt: not updating

Chip

  • AriaLabel: Sets "arialabel" instead of aria-label
  • selected: not updating

Date-Picker

  • name: not updating
  • min/max: description should mention that it needs to be formatted as yyyy-mm-dd
  • aria-label: not updating
  • target: Should be a single select control in storybook

Footer

  • A basic story control for socials and links would be nice

Navbar

  • ifxNavbarMobileMenuIsOpen: event missing
  • target: Should be a single select control in storybook

Sidebar

  • target: Should be a single select control in storybook

Search Bar

  • disabled: Update description
  • isOpen: Update description

Table (Basic)

  • rowHeight: not updating

@agata-kim
Copy link
Collaborator

Hello Fabian and thank you for your review!

Accordion

  • mutable: Improve description ✅

Card

  • alt: not updating ✅

Chip

  • AriaLabel: Sets "arialabel" instead of aria-label: 🟡 It is also called AriaLabel in the .tsx file because it is a Stencil property. Will it be still setted correctly if the property in the Storybook will be renamed to aria-label?
  • selected: not updating ✅

Date-Picker

  • name: not updating ✅
  • min/max: description should mention that it needs to be formatted as yyyy-mm-dd ✅
  • aria-label: not updating ✅
  • target: Should be a single select control in storybook 🟡 Could you specify why should we display target since it is not a prop?

Footer

  • A basic story control for socials and links would be nice ✅ Added href and icon control.

Navbar

  • ifxNavbarMobileMenuIsOpen: event missing ✅ We considered to remove this event because it is nowhere used.
  • target: Should be a single select control in storybook ✅

Sidebar

  • target: Should be a single select control in storybook ✅

Search Bar

  • disabled: Update description ✅
  • isOpen: Update description ✅

Table (Basic)

  • rowHeight: not updating ✅

@tishoyanchev tishoyanchev force-pushed the 1566-storybook-consistency-and-ui-enhancement branch 2 times, most recently from 4301901 to c16f763 Compare January 14, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook: consistency and UI enhancement
4 participants