Kwxm/spec/no flat for bls #5690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwxm
added
Specification
No Changelog Required
kwxm
commented
Dec 19, 2023
There was a problem hiding this comment.
I added these changes for the list/pair/data issue but then decided to do that in a separate PR. They'll make more sense when I do that.
kwxm
commented
Dec 19, 2023
| @@ -17,7 +17,7 @@ \subsection{Sets} | |||
| \item $\B^*$ is the set of all bytestrings. | |||
| \item $\Z = \{\ldots, -2, -1, 0, 1, 2, \ldots\}$. | |||
| \item $\mathbb{F}_q$ denotes a finite field with $q$ elements ($q$ a prime power). | |||
| \item $\mathbb{F}_q^*$ denotes the multiplicative group of nonzero elements of $\mathbb{F}_q$. | |||
| \item $\units{\mathbb{F}} = \mathbb{F}\setminus\{0\}$ denotes the multiplicative group of nonzero elements of a field $\mathbb{F}$. | |||
There was a problem hiding this comment.
This is to avoid confusion with the X^* notation for sequences of elements of a set X. Both F^* and F^× are used in the mathematical literature.
|
I'll just merge this: it's not very complicated and the reviewers are on holiday. |
v0d1ch
pushed a commit
to v0d1ch/plutus
that referenced
this pull request
Dec 6, 2024
* Change symbol for units of field to avoid confusion * No flat serialisation for BLS12-381 elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the specifcation to reflect the changes made in #5663, where we removed direct serialisation of the BLS12-31 G1 and G2 element types. The main changes are in Note 4 on pages 38-39 and Section C.3.4 on pages 55-56. There's a bit of repetition, but I thought that would probably make it more obvious what was going on. I'll follow this up shortly with a separate PR to add the concrete syntax for lists/pairs/data.
Rendered version: plutus-core-specification.pdf