Kwxm/conformance/improve filename check #6730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unisay
approved these changes
Dec 4, 2024
kwxm
commented
Dec 20, 2024
| case inputFile of | ||
| [] -> error $ "Input file missing in " <> dir | ||
| _:_:_ -> error $ "More than 1 input files in " <> dir | ||
| [file] -> do |
There was a problem hiding this comment.
At this point it checks that there's exactly one .uplc file in the directory, but it doesn't check that the filename matches the name of the directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6660. See the issue for a description of the problem. The README file was a bit out of date so I updated that as well.
A related issue is #6714: that'll be dealt with in a separate PR.