-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Scholar submodule modification for properly taking custom xpaths for authors #323
Open
dnwk
wants to merge
97
commits into
Islandora:7.x
Choose a base branch
from
dnwk:Kun-Dev-GoogleScholar
base: 7.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
b6429eb
Version bump to 7.x-1.12
bryjbrown be762ec
Update Readme.md position replacement.
cdeaneGit 7d4a963
add new screenshot for XPATH CONFIGURATION
cdeaneGit 68d54fd
Update Readme add image location
cdeaneGit 31ee45c
Update Readme insert JPG replacement file
cdeaneGit bc987d5
Add revised screenshot
cdeaneGit a53c744
Merge branch 'ISLANDORA-2338' of https://github.com/cdeaneGit/islando…
cdeaneGit 3dca758
Update Readme. Add trim version of new image.
cdeaneGit a92549a
Update Readme -- cleanup
cdeaneGit 6d33012
new screenshot in PNG format
cdeaneGit c490222
Revise README to use PNG file
cdeaneGit 20bc58b
add code for new screenshot to readme
cdeaneGit b8a8d4f
Add comments for correct image handling
cdeaneGit 0786760
Update Readme to replace old image with new.
cdeaneGit 9640f92
Delete XPATH_config2_trim.JPG
cdeaneGit 034ba0a
Delete XPATH_config2_full.JPG
cdeaneGit 337c331
Delete XPATH_config2_trim.PNG
cdeaneGit e35f6c7
Merge pull request #310 from cdeaneGit/ISLANDORA-2338
bryjbrown 62597f3
ISLANDORA-2409:Scholar is vulnerable to a stored XSS exploit. (#321)
willtp87 9bdf81d
It will now read Author Drupal variable.
36c222f
Remove RoleTerm restriction. Taking authors xpath settings and use di…
afa43bd
Deal with Middle Name as in MODS they are also marked as "given"
664495e
processed modification and add suggestion from Pat.
7aec57f
ISLANDORA-2349 changes to pull request template
manez 86e7ba6
Move islandora_scholar_embargo earlier
bondjimbond 75dae2e
Add entity to dependencies list to please Travis
bondjimbond 30fd7e5
ISLANDORA-2398: Adds subtitle to citation_title metatag (#315)
bryjbrown 763b0ec
Add self-transform to default form associations
0f0f215
Pull in citeproc-php 2.1.7
jonathangreen 3b21155
ISLANDORA-2409: Selectable colorspace for PREVIEW/TN (#318)
BrandonMorr 867dee3
Allow PHP 5.3.3 to fail
whikloj 1f0282d
It will now read Author Drupal variable.
a70c629
Remove RoleTerm restriction. Taking authors xpath settings and use di…
9f1d8d0
Deal with Middle Name as in MODS they are also marked as "given"
066f457
processed modification and add suggestion from Pat.
a89c94d
Merge remote-tracking branch 'remotes/origin/Kun-Dev-GoogleScholar' i…
71c096d
Version bump to 7.x-1.12
bryjbrown 8387017
Update Readme.md position replacement.
cdeaneGit 70e6e48
add new screenshot for XPATH CONFIGURATION
cdeaneGit 1cade02
Add revised screenshot
cdeaneGit f157147
Update Readme add image location
cdeaneGit b48fb31
Update Readme insert JPG replacement file
cdeaneGit 3790364
Update Readme. Add trim version of new image.
cdeaneGit 49d390c
new screenshot in PNG format
cdeaneGit 6120d64
Delete XPATH_config2_trim.JPG
cdeaneGit ce8f6f2
Delete XPATH_config2_full.JPG
cdeaneGit 95b15fe
Delete XPATH_config2_trim.PNG
cdeaneGit 739172f
It will now read Author Drupal variable.
d3b167e
Remove RoleTerm restriction. Taking authors xpath settings and use di…
61b3938
Deal with Middle Name as in MODS they are also marked as "given"
ed80525
processed modification and add suggestion from Pat.
dc5912c
It will now read Author Drupal variable.
c8d1080
Remove RoleTerm restriction. Taking authors xpath settings and use di…
3432d7a
Deal with Middle Name as in MODS they are also marked as "given"
f1fbf2b
processed modification and add suggestion from Pat.
5304b62
Merge branch 'Kun-Dev-GoogleScholar' of github.com:dnwk/islandora_sch…
1a38de5
Version bump to 7.x-1.12
bryjbrown 94f255c
Update Readme.md position replacement.
cdeaneGit 2fbe0ca
add new screenshot for XPATH CONFIGURATION
cdeaneGit 9d8c3e5
Add revised screenshot
cdeaneGit 698e3f0
Update Readme add image location
cdeaneGit 175ed8f
Update Readme insert JPG replacement file
cdeaneGit 7ea3084
Update Readme. Add trim version of new image.
cdeaneGit 9fdb4a9
new screenshot in PNG format
cdeaneGit f87e2cb
Delete XPATH_config2_trim.JPG
cdeaneGit 2ebbb57
Delete XPATH_config2_full.JPG
cdeaneGit eb22115
Delete XPATH_config2_trim.PNG
cdeaneGit 5bf9fd5
It will now read Author Drupal variable.
51a2f29
Remove RoleTerm restriction. Taking authors xpath settings and use di…
007e572
Deal with Middle Name as in MODS they are also marked as "given"
abc83f4
processed modification and add suggestion from Pat.
ff6b935
It will now read Author Drupal variable.
0b35721
Remove RoleTerm restriction. Taking authors xpath settings and use di…
1ab7b2f
Deal with Middle Name as in MODS they are also marked as "given"
794fdd7
processed modification and add suggestion from Pat.
9ea6228
Update Readme.md position replacement.
cdeaneGit 49946cd
add new screenshot for XPATH CONFIGURATION
cdeaneGit d8b91cb
Add revised screenshot
cdeaneGit 2ec17fa
Update Readme add image location
cdeaneGit c9bd494
Update Readme insert JPG replacement file
cdeaneGit 1a39e72
Update Readme. Add trim version of new image.
cdeaneGit 1e3f3df
new screenshot in PNG format
cdeaneGit bc32067
Delete XPATH_config2_trim.JPG
cdeaneGit e0402e4
Delete XPATH_config2_full.JPG
cdeaneGit f6e7b4c
Delete XPATH_config2_trim.PNG
cdeaneGit de32f94
It will now read Author Drupal variable.
9a6da51
Remove RoleTerm restriction. Taking authors xpath settings and use di…
a8f0f38
Deal with Middle Name as in MODS they are also marked as "given"
5094d17
processed modification and add suggestion from Pat.
b1400f8
It will now read Author Drupal variable.
534787a
Remove RoleTerm restriction. Taking authors xpath settings and use di…
c7a802e
Deal with Middle Name as in MODS they are also marked as "given"
fa1267c
processed modification and add suggestion from Pat.
6779996
Merge branch 'Kun-Dev-GoogleScholar' of github.com:dnwk/islandora_sch…
e85f999
Updating Google Scholar tag creation, so that when generating author …
2e99a26
Merge branch '7.x' of https://github.com/Islandora/islandora_scholar …
de262e5
Merge branch '7.x' into Kun-Dev-GoogleScholar
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of a mess. Is this the intended output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure which one are you referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry for the long delay on answering you -- I didn't get notified that you replied!)
The README file has a lot of weird text in it:
Also, if I look at your README in your fork: https://github.com/dnwk/islandora_scholar
The image links are broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it by pulling the file from upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The messy stuff is still there.